fix: Fix invoker to work when using dataclass with from_dict but dataclass… #9434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is already given
Pull Request Test Coverage Report for Build 15210934031Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjrl
requested review from
dfokina,
anakin87 and
vblagoje
and removed request for
a team
|
@vblagoje I'd also appreciate your review on this since you worked on ComponentTool in the past |
anakin87
reviewed
May 23, 2025
vblagoje
reviewed
May 26, 2025
| @@ -159,15 +159,19 @@ def component_invoker(**kwargs): | |||
| target_type = get_args(param_type)[0] if get_origin(param_type) is list else param_type | |||
| if hasattr(target_type, "from_dict"): | |||
| if isinstance(param_value, list): | |||
| param_value = [target_type.from_dict(item) for item in param_value if isinstance(item, dict)] | |||
| resolved_param_value = [ | |||
| target_type.from_dict(item) if isinstance(item, dict) else item for item in param_value | |||
There was a problem hiding this comment.
@sjrl - just one clarification - so the only difference to previous code state is that we now include other items in the list - that are not dicts?
There was a problem hiding this comment.
Yeah we keep other items in the list (or really all items in a list) that aren't dicts. If we don't do this and a user passes this
agent_tool.invoke(messages=[ChatMessage.from_user("Tell me the latest news about gpus")])we actually run the agent_tool with
messages=[ChatMessage.from_user("Tell me the latest news about gpus")]
# turns into
messages=[]
# then we run Agent Tool with an empty list of messagesThere was a problem hiding this comment.
This is relevant in two cases:
- If a user is trying to use a tool manually with
invokeor within a custom component - If we pass
inputs_from_stateto a Tool which are already fully formed dataclasses. E.g. If I pass themessagesfrom State into the input of a Tool that accepts ChatMessages. I wouldn't expect the invoke function to then remove all the messages.
julian-risch
pushed a commit
that referenced
this pull request
May 26, 2025
…class… (#9434) * Fix invoker to work when using dataclass with from_dict but dataclass is already given * add reno * Add unit test * Remove line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Fix invoker to work when using dataclass with from_dict but dataclas is already given
Updated the
component_invokermethod to allow fully formed dataclass objects to pass through. Otherwise we silently remove the parameter value.Originally found by @bilgeyucel when creating an tool using Agent + ComponentTool and calling
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.